[asterisk-dev] [Code Review] Fix asttest's Asterisk version extraction

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1701/
-----------------------------------------------------------

(Updated Jan. 28, 2012, 9:40 p.m.)


Review request for Asterisk Developers.


Summary
-------

This patch changes how the lua-based tests determine the Asterisk version.  Previously, like the version.py library, the astlib.lua library was extracting this from the version.h header file.  Now it also spawns an Asterisk process with the '-V' command line switch and reads the version from the output.

This should resolve the failing tests in trunk:
* rfc2833_dtmf_detect
* manager/action-events-response
* queues/position_priority_maxlen
* cdr/blind-transfer-accountcode

This patch also addresses Russell and Walter's last comments on version.py in https://reviewboard.asterisk.org/r/1695/.  Specifically, it re-raises caught OSError exceptions after logging them, and places the setting of the static variable in a private method.


Diffs (updated)
-----

  /asterisk/trunk/asttest/lib/lua/astlib.lua 3021 
  /asterisk/trunk/lib/python/asterisk/version.py 3021 

Diff: https://reviewboard.asterisk.org/r/1701/diff


Testing
-------

Ran on local development machine; all currently failing trunk tests passed.


Thanks,

Matt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120129/1d1581f6/attachment.htm>