[asterisk-dev] [Code Review] Audit of ao2_iterator_init() usage for v1.8

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1697/
-----------------------------------------------------------

(Updated Jan. 27, 2012, 10:18 a.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Address mmichelson's comments.


Summary
-------

I audited the usage of the ao2_iterator_init() function in the v1.8 code base.

I checked that the iterator was destroyed and that the current iteration object reference was not leaked.

This patch fixes numerous reference leaks and missing ao2_iterator_destroy() calls as a result.


Diffs (updated)
-----

  /branches/1.8/apps/app_chanspy.c 352916 
  /branches/1.8/apps/app_queue.c 352916 
  /branches/1.8/channels/chan_iax2.c 352916 
  /branches/1.8/channels/chan_sip.c 352916 
  /branches/1.8/include/asterisk/indications.h 352916 
  /branches/1.8/main/indications.c 352916 
  /branches/1.8/main/pbx.c 352916 
  /branches/1.8/main/taskprocessor.c 352916 
  /branches/1.8/res/res_odbc.c 352916 
  /branches/1.8/res/res_srtp.c 352916 
  /branches/1.8/res/snmp/agent.c 352916 

Diff: https://reviewboard.asterisk.org/r/1697/diff


Testing
-------

It compiles. :)


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120127/44558dfb/attachment.htm>