[asterisk-dev] [Code Review] Add a SIP nat=auto setting

[Luke Hamburg]

This is a really useful patch! 

 

One question:

Would nat=auto be valid for the [general] context of sip.conf as well?  Or should this always be explicitly yes/no.  I ask because after the recent vulnerability related to having disparate nat= settings for peers I haven't been setting the nat= value per-peer, and instead set it once at [general].

 

Luke

 

From: asterisk-dev-bounces at lists.digium.com [mailto:asterisk-dev-bounces at lists.digium.com] On Behalf Of Simon Perreault
Sent: Friday, January 27, 2012 8:55 AM
To: Simon Perreault; Terry Wilson; Asterisk Developers
Subject: Re: [asterisk-dev] [Code Review] Add a SIP nat=auto setting

 


This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/1698/ 

 

Ship it!

Looks good.
 
It is similar to what Cisco SBC does:
http://www.cisco.com/en/US/docs/routers/asr1000/configuration/guide/sbcu/sbc_nat.html#wp1000953
 
Could nat=auto become the new default?

 


 <https://reviewboard.asterisk.org/r/1698/diff/2/?file=23678#file23678line16228> /trunk/channels/chan_sip.c (Diff revision 2) 


static void check_via(struct sip_pvt *p, struct sip_request *req)
		
16228

                                   ast_debug(3, "Global nat=auto, so force nat=yes so we reply to non-peers like we would peers.\n");
The use of the term "peer" is confusing me. I have no idea what the sentence means.

 

- Simon

 

On January 26th, 2012, 8:28 p.m., Terry Wilson wrote:


Review request for Asterisk Developers.

By Terry Wilson.

Updated Jan. 26, 2012, 8:28 p.m.


Description 


First, this patch as originally posted is from JIRA user pedro-garcia. It has been in JIRA for a long while, and has finally come up to be considered. There were some changes that I wanted to made to the original patch, so I tried contacting the author to get them to put the patch on reviewboard, but after a week I got no response. So, I'm putting the original patch up, then will immediately add a review with my changes. Many thanks to pedro-garcia for his contribution.