[asterisk-dev] [Code Review] avoid cppcheck warnings

junky reviewboard at asterisk.org
Thu Jan 26 21:38:59 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1651/
-----------------------------------------------------------

(Updated Jan. 26, 2012, 9:38 p.m.)


Review request for Asterisk Developers.


Changes
-------

This is to fix the ast_expr2.fl as per Corydon's request.
Also changed chan->language to ast_channel_language(chan), since the opaque ast_channel's patch is already in trunk.


Summary
-------

By running cppcheck 1.52, i realized there was many errors/warnings.

This patch fixes many of those.


Diffs (updated)
-----

  trunk/addons/chan_mobile.c 352913 
  trunk/addons/chan_ooh323.c 352913 
  trunk/apps/app_alarmreceiver.c 351181 
  trunk/apps/app_chanspy.c 352913 
  trunk/apps/app_dial.c 352913 
  trunk/apps/app_disa.c 352913 
  trunk/apps/app_minivm.c 352913 
  trunk/apps/app_osplookup.c 351181 
  trunk/apps/app_queue.c 352913 
  trunk/apps/app_voicemail.c 352913 
  trunk/channels/chan_dahdi.c 352913 
  trunk/channels/chan_iax2.c 352913 
  trunk/channels/chan_misdn.c 352913 
  trunk/channels/chan_skinny.c 352913 
  trunk/channels/chan_usbradio.c 352913 
  trunk/formats/format_h263.c 351181 
  trunk/funcs/func_env.c 351181 
  trunk/funcs/func_odbc.c 352913 
  trunk/funcs/func_strings.c 351181 
  trunk/main/acl.c 352913 
  trunk/main/ast_expr2.fl 352913 
  trunk/main/ast_expr2f.c 352913 
  trunk/main/pbx.c 352913 
  trunk/main/udptl.c 352913 
  trunk/utils/astman.c 351181 

Diff: https://reviewboard.asterisk.org/r/1651/diff


Testing
-------

still compile fine.
Shouldn't have any impact on the code execution.


Thanks,

junky

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120127/cc13d255/attachment.htm>


More information about the asterisk-dev mailing list