[asterisk-dev] [Code Review] Remove development header dependency for asterisk version

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1695/#review5318
-----------------------------------------------------------



asterisk/trunk/lib/python/asterisk/version.py
<https://reviewboard.asterisk.org/r/1695/#comment9866>

    looks like this arg can be removed



asterisk/trunk/lib/python/asterisk/version.py
<https://reviewboard.asterisk.org/r/1695/#comment9865>

    I'm not sure these exceptions should be ignored.  I would just let them get raised.  Otherwise, if it fails, it's going appear to be a more bizarre failure later.



asterisk/trunk/lib/python/asterisk/version.py
<https://reviewboard.asterisk.org/r/1695/#comment9864>

    This can just be:
    
    AsteriskVersion.ast_version = process.stdout.read()


- Russell


On Jan. 26, 2012, 4:27 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1695/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2012, 4:27 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Like the title says, we'll now use the asterisk binary over the development headers to figure out which version of asterisk is installed.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/version.py 3019 
> 
> Diff: https://reviewboard.asterisk.org/r/1695/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120126/35e95364/attachment.htm>