[asterisk-dev] [Code Review] Remove some dead code found in _sip_show_peers()
wdoekes
reviewboard at asterisk.org
Thu Jan 26 14:54:19 CST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1696/#review5313
-----------------------------------------------------------
trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1696/#comment9858>
for<space>(
trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1696/#comment9860>
Isn't the lack of indentation here more worrisome than the missing braces above?
(And the same issue with astman_append below.)
- wdoekes
On Jan. 26, 2012, 10:59 a.m., Paul Belanger wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1696/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2012, 10:59 a.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> I was poking around in chan_sip last night (scary right?) and notice what appears to be some dead code. This patch removes it and also includes come coding guidelines.
>
>
> Diffs
> -----
>
> trunk/channels/chan_sip.c 352754
>
> Diff: https://reviewboard.asterisk.org/r/1696/diff
>
>
> Testing
> -------
>
> local development box
>
>
> Thanks,
>
> Paul
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120126/64163094/attachment-0001.htm>
More information about the asterisk-dev
mailing list