[asterisk-dev] [Code Review] Remove development header dependency for asterisk version

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1695/#review5309
-----------------------------------------------------------


Double-check that this doesn't create any 'fake' configuration folders when called from TestCase, asterisk, TestConfig, and other places higher then the base runtests.py script.  I don't think it will - but if it does those need to be handled somehow.


asterisk/trunk/lib/python/asterisk/version.py
<https://reviewboard.asterisk.org/r/1695/#comment9852>

    The version_str should probably be a static to the AsteriskVersion class:
    1. Once it is set within a process, we wouldn't expect the Asterisk version to change
    2. Every subsequent creation of an AsteriskVersion object could check to see if the version number was assigned - if so, it wouldn't need to spawn a process
    
    Otherwise, the asterisk wrapper class will be spawning a lot of children processes to wait on.



asterisk/trunk/lib/python/asterisk/version.py
<https://reviewboard.asterisk.org/r/1695/#comment9853>

    You shouldn't swallow any exceptions here.  It should be logged that we couldn't determine the version as the process failed to spawn.



asterisk/trunk/runtests.py
<https://reviewboard.asterisk.org/r/1695/#comment9851>

    You can't remove this yet.  We still check buildoptions for some tests.
    
    When a run-time mechanism for that is available, then this can be removed.


- Matt


On Jan. 26, 2012, 10:39 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1695/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2012, 10:39 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Like the title says, we'll now use the asterisk binary over the development headers to figure out which version of asterisk is installed.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/version.py 3015 
>   asterisk/trunk/runtests.py 3015 
> 
> Diff: https://reviewboard.asterisk.org/r/1695/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120126/dbdd6271/attachment-0001.htm>