[asterisk-dev] [Code Review] Add result variable to make it possible to know that a CALENDAR_WRITE has failed.

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1692/
-----------------------------------------------------------

(Updated Jan. 26, 2012, 7:33 a.m.)


Review request for Asterisk Developers and junky.


Changes
-------

Don't do the write on failure, but do set the variable.


Summary
-------

This patch adds a CALENDAR_SUCCESS=1/0 variable that is set to show whether or not CALENDAR_WRITE has passed. This patch is basically junky's patch from the issue with CALENDAR_SUCCESS=1/0 instead of CALENDARSTATUS="SUCCESS"/"FAILURE" so that one can just do GotoIf(${CALENDAR_SUCCESS}?success:failure). Also changed is adding some debugging for caldav PUT responses and not treating responses with no body as an error (as a PUT gets a 201 Created with no body).


This addresses bug ASTERISK-16903.
    https://issues.asterisk.org/jira/browse/ASTERISK-16903


Diffs (updated)
-----

  /trunk/res/res_calendar.c 352510 
  /trunk/res/res_calendar_caldav.c 352510 
  /trunk/res/res_calendar_exchange.c 352510 

Diff: https://reviewboard.asterisk.org/r/1692/diff


Testing
-------

Wrote to a caldav calendar and verified proper creation of event and CALENDAR_SUCCESS values.


Thanks,

Terry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120126/f7a3e3fe/attachment.htm>