[asterisk-dev] [Code Review] rfc4235 - Section 4.1: Versions MUST be representable using a non-negative 32 bit integer.

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1694/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

printf %d may print negative version numbers, if a subscription exists for long enough.

I'm not confortable with %u on 32 or 64 bit systems.

Should I perhaps use a type cast, printf("%lu\n", (unsigned long)dialogver);


Diffs
-----

  trunk/channels/chan_sip.c 350022 
  trunk/channels/sip/include/sip.h 350022 

Diff: https://reviewboard.asterisk.org/r/1694/diff


Testing
-------

Compiles


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120126/80379d56/attachment.htm>