[asterisk-dev] [Code Review] cleanup dialog-info+xml Notify dialog

Alec Davis reviewboard at asterisk.org
Wed Jan 25 19:46:56 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1693/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Make consistant with the other dialog types, (and more human readable)
Simply added "\n" in 3 places

Sip debug previously looked like;

<?xml version="1.0"?><dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="715" state="full" entity="sip:8523 at 192.168.x.xx"><dialog id="8523">
<state>terminated</state>
</dialog>
</dialog-info>

Sip debug now looks like below;

User-Agent: Asterisk PBX 1.8.8.2
Subscription-State: active
Event: dialog
Content-Type: application/dialog-info+xml
Content-Length: 207

<?xml version="1.0"?>
<dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="715" state="full" entity="sip:8523 at 192.168.x.xx">
<dialog id="8523">
<state>terminated</state>
</dialog>
</dialog-info>


Diffs
-----

  trunk/channels/chan_sip.c 351705 

Diff: https://reviewboard.asterisk.org/r/1693/diff


Testing
-------

on a box with 116 registered hints.


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120126/0a63256b/attachment.htm>


More information about the asterisk-dev mailing list