[asterisk-dev] [Code Review] Cleanup some SIP registry-related memory leaks

Mark Michelson reviewboard at asterisk.org
Wed Jan 25 09:07:03 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1689/#review5283
-----------------------------------------------------------

Ship it!


Good finds. Is this in regard to a bug you were working on or did you just happen to notice this?

- Mark


On Jan. 24, 2012, 6:15 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1689/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2012, 6:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> 1) Be sure and free at unloadthe epa_backend we allocate at startup
> 2) Do the same sip_registry cleanup at unload we do at reload
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 351862 
> 
> Diff: https://reviewboard.asterisk.org/r/1689/diff
> 
> 
> Testing
> -------
> 
> Verified that loading and unloading the module didn't leave around stuff for 'memory show allocations chan_sip.c' to find.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120125/62b3ae14/attachment.htm>


More information about the asterisk-dev mailing list