[asterisk-dev] [Code Review] Improvements to Asterisk parking (Repost of review 963)

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1674/#review5219
-----------------------------------------------------------


A note in UPGRADE.txt or CHANGES should be made to indicate that the comebacktoorigin behavior is now per parkinglot instead of global.  It is the only option that was configurable before.


/trunk/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/1674/#comment9731>

    Copy "Set per parking lot." line from above for here for consistency.
    
    Do the same for the other new options.



/trunk/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/1674/#comment9735>

    There really should be two spaces at the end of a sentence.  Not just one space.



/trunk/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/1674/#comment9734>

    Unnecessary blank line.



/trunk/configs/features.conf.sample
<https://reviewboard.asterisk.org/r/1674/#comment9732>

    I see red here.
    Also the PARKER name has been noted as being a bad name in another review note.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/1674/#comment9736>

    You're using spaces here when the other default options are lined up with tabs.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/1674/#comment9738>

    These should be dimensioned by AST_MAX_CONTEXT.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/1674/#comment9737>

    Make comebacktoorigin a bit field and put it with the others below.
    
    Change the comment to:
    "TRUE if a timed out parked call goes back to the parker."



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/1674/#comment9742>

    It is /*!
    not /*!<
    for this location.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/1674/#comment9741>

    Wrap long line.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/1674/#comment9739>

    The LOG_DEBUG statements here do not add much value and should be removed.
    
    FYI LOG_DEBUG statements should be ast_debug(1, ) statements instead.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/1674/#comment9740>

    Add a cfg->comebackcontext check as it should not be empty especially if comebacktoorigin is no(false).



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/1674/#comment9733>

    Red here.  Spacing inconsistency.
    
    Wrap long lines at 90 columns.


- rmudgett


On Jan. 17, 2012, 10:09 a.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1674/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2012, 10:09 a.m.)
> 
> 
> Review request for Asterisk Developers, rmudgett and Mitch Sharp.
> 
> 
> Summary
> -------
> 
> Many moons ago, Mitch Sharp posted some updates for Asterisk parking (https://reviewboard.asterisk.org/r/963/). Here is the copy and pasted text from that review description:
> ------
> I posted a patch to issues a few weeks ago that duplicated some existing features.  (https://issues.asterisk.org/view.php?id=17947)
> 
> I have reworked it to extend the existing parking behavior.
> 
> This patch does the following:
> - Make comebacktoorigin a per-parkinglot option.
> - Make parkedmusicclass a per-parkinglot option, and make sure parkinglot->parking_con_dial gets set to "park-dial" for additional parking lots instead of being left NULL (already have a patch in issues for this for as a fix for 1.8.0-beta4, https://issues.asterisk.org/view.php?id=17946)
> - Adds a per-parkinglot option comebackcontext, which defaults to the usual 'parkedcallstimeout' context.  Allows the user to handle timed out calls for different parking lots in different contexts.
> - Adds a per-parkinglot option comebackdialtime, which allows user to override the dial time specified in automatically created extensions when comebacktoorigin=yes.
> - Adds channel variable PARKER to timed out calls, so user can easily dial the original device that parked the call if comebacktoorigin=no.
> - Update CLI command 'features show' to include the comebacktoorigin, comebackcontext and comebackdialtime values.
> - Updated /configs/features.conf.sample
> 
> This patch doesn't change any default behavior.
> 
> Looking forward to some feedback.
> ------
> 
> It got some review feedback, but there was never a new version of the patch posted. I've taken the original patch and updated it to apply to Asterisk trunk as it is now.
> 
> As far as I can tell, I've got the patch behaving exactly how it was as originally written. There is a spot that seems odd to me, and I'll highlight it in the diff.
> 
> I've included Richard in this review since he knows parking a lot better than most people do at the moment since he did some refactoring of it recently. 
> 
> 
> This addresses bug ASTERISK-16643.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16643
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/features.conf.sample 350960 
>   /trunk/main/features.c 350960 
> 
> Diff: https://reviewboard.asterisk.org/r/1674/diff
> 
> 
> Testing
> -------
> 
> I have set up parking lots and ensured that the new options take effect when set and that the defaults are used when not set.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120119/c87f346e/attachment-0001.htm>