[asterisk-dev] [Code Review]: safe_asterisk: Allow overriding TTY and CONSOLE in startup.d

[Tilghman Lesher]

> On Nov. 30, 2011, 6:05 p.m., Tilghman Lesher wrote:
> > /trunk/contrib/scripts/safe_asterisk, lines 146-149
> > <https://reviewboard.asterisk.org/r/1601/diff/1/?file=22019#file22019line146>
> >
> >     Given that there is output above this point, this part should probably remain at the top of the script.
> 
> Tzafrir Cohen wrote:
>     I considered fixing that, but then again, why does safe_asterisk write to the controlling terminal? This keeps annoying me. It "daemonizes, but keeps in touch with the terminal. It doesn't play nicely. Also note the usage of 'echo' vs. 'message' (which writes to standard error by default, and also optionally elsewhere).
>     
>     Another issue: the new location still does not allow overriding UMAKS and MAXFILES. I can move it further up. But I wonder if anybody actually relies on those being already set up in a startup.d script.

Well, but this isn't a startup.d script.  It may have evolved into one in some cases (see other places in the tree), but this one is the standalone that gets installed into /usr/sbin.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1601/#review4893
-----------------------------------------------------------


On Nov. 30, 2011, 1:19 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1601/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2011, 1:19 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Source the files in /etc/asterisk/startup.d (if any) a bit earlier in the safe_asterisk script to allow overriding the variables TTY and CONSOLE as well.
> 
> 
> Diffs
> -----
> 
>   /trunk/contrib/scripts/safe_asterisk 346471 
> 
> Diff: https://reviewboard.asterisk.org/r/1601/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120121/4d61efb1/attachment.htm>