[asterisk-dev] [Code Review] Fixes for sending SIP MESSAGE outside of calls.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1683/#review5260
-----------------------------------------------------------



/branches/10/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1683/#comment9797>

    You should also block Supported, Require, and CSeq. Since there might be other disallowed headers we haven't considered, it would be a good idea to create an array with all the header names we don't allow to be added, and use a function to look them up. This will be easier to maintain and potentially be nicer looking than the if chain currently in use.


- Mark


On Jan. 20, 2012, 3:55 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1683/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2012, 3:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Fixes done by this patch:
> * Expand SIP short header names so the dialplan and other code only has to deal with the full names.
> 
> * Fix authenticate MESSAGE losing custom headers added by the MESSAGE_DATA function in the authorization attempt.
> 
> * Block user from adding standard headers that are added automatically. (To, From,...)
> 
> * Pass up better From header contents for SIP to use.  Now is in the "display-name" <URI> format expected by MessageSend.
> 
> * Decrement Max-Forwards header if the user transferred it from an incoming message.
> 
> * Allow the user to override the Content-Type header contents sent by MessageSend.
> 
> * Documents what SIP expects in the MessageSend(from) parameter.
> 
> 
> This addresses bugs ASTERISK-18917, ASTERISK-18992 and ASTERISK-19058.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18917
>     https://issues.asterisk.org/jira/browse/ASTERISK-18992
>     https://issues.asterisk.org/jira/browse/ASTERISK-19058
> 
> 
> Diffs
> -----
> 
>   /branches/10/channels/sip/include/sip.h 351950 
>   /branches/10/main/message.c 351950 
>   /branches/10/channels/chan_sip.c 351950 
> 
> Diff: https://reviewboard.asterisk.org/r/1683/diff
> 
> 
> Testing
> -------
> 
> Updated SIP MESSAGE external tests with more cases that cover some of the items fixed.  The tests pass.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120121/71dad4c2/attachment-0001.htm>