[asterisk-dev] [Code Review] Improvements to Asterisk parking (Repost of review 963)

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1674/
-----------------------------------------------------------

(Updated Jan. 20, 2012, 10:12 a.m.)


Review request for Asterisk Developers, rmudgett and Mitch Sharp.


Changes
-------

Addressed Richard's comments.


Summary
-------

Many moons ago, Mitch Sharp posted some updates for Asterisk parking (https://reviewboard.asterisk.org/r/963/). Here is the copy and pasted text from that review description:
------
I posted a patch to issues a few weeks ago that duplicated some existing features.  (https://issues.asterisk.org/view.php?id=17947)

I have reworked it to extend the existing parking behavior.

This patch does the following:
- Make comebacktoorigin a per-parkinglot option.
- Make parkedmusicclass a per-parkinglot option, and make sure parkinglot->parking_con_dial gets set to "park-dial" for additional parking lots instead of being left NULL (already have a patch in issues for this for as a fix for 1.8.0-beta4, https://issues.asterisk.org/view.php?id=17946)
- Adds a per-parkinglot option comebackcontext, which defaults to the usual 'parkedcallstimeout' context.  Allows the user to handle timed out calls for different parking lots in different contexts.
- Adds a per-parkinglot option comebackdialtime, which allows user to override the dial time specified in automatically created extensions when comebacktoorigin=yes.
- Adds channel variable PARKER to timed out calls, so user can easily dial the original device that parked the call if comebacktoorigin=no.
- Update CLI command 'features show' to include the comebacktoorigin, comebackcontext and comebackdialtime values.
- Updated /configs/features.conf.sample

This patch doesn't change any default behavior.

Looking forward to some feedback.
------

It got some review feedback, but there was never a new version of the patch posted. I've taken the original patch and updated it to apply to Asterisk trunk as it is now.

As far as I can tell, I've got the patch behaving exactly how it was as originally written. There is a spot that seems odd to me, and I'll highlight it in the diff.

I've included Richard in this review since he knows parking a lot better than most people do at the moment since he did some refactoring of it recently. 


This addresses bug ASTERISK-16643.
    https://issues.asterisk.org/jira/browse/ASTERISK-16643


Diffs (updated)
-----

  /trunk/configs/features.conf.sample 351309 
  /trunk/main/features.c 351309 

Diff: https://reviewboard.asterisk.org/r/1674/diff


Testing
-------

I have set up parking lots and ensured that the new options take effect when set and that the defaults are used when not set.


Thanks,

Mark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120120/ad80a8ef/attachment.htm>