[asterisk-dev] [Code Review] Eliminate port doubling in SIP notification header Message-Account

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1678/
-----------------------------------------------------------

Review request for Asterisk Developers, Mark Michelson and Matt Jordan.


Summary
-------

This patch prevents the domain string from getting mangled during the initreqprep step by moving the initialization to before its immediate use.  It also documents this pitfall for the ast_sockaddr_stringify functions.

This only resolves part 1 of the reporter's issues.  The reporter's patch is perfectly adequate for part 2, but it doesn't apply to 1.8 while this part of the issue does.


This addresses bug ASTERISK-19057.
    https://issues.asterisk.org/jira/browse/ASTERISK-19057


Diffs
-----

  /branches/1.8/channels/chan_sip.c 351503 
  /branches/1.8/include/asterisk/netsock2.h 351503 

Diff: https://reviewboard.asterisk.org/r/1678/diff


Testing
-------

Code tracing and reproduction of the issue coupled with making sure this actually fixed it.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120119/0eeb0d8c/attachment.htm>