[asterisk-dev] [Code Review] get_rpid function also didnt work right like the get_pai function

schmidts reviewboard at asterisk.org
Thu Jan 19 09:45:51 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1677/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

like the get_pai function the get_rpid function also didnt work well. By changing it to use the reqresp functions it works better.

i also changed some var names for better understanding,

the part about finding the privacy and screen params is very ugly but i dont have find a good way to solve this cause there isnt allready a reqresp parser for this.


Diffs
-----

  team/schmidts/unleash-the-beast/channels/chan_sip.c 350974 

Diff: https://reviewboard.asterisk.org/r/1677/diff


Testing
-------

tested with different RPID header values and privacy and screen settings.


Thanks,

schmidts

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120119/c5eaa609/attachment.htm>


More information about the asterisk-dev mailing list