[asterisk-dev] [Code Review]: Allow specifying which MixMonitor to stop

[telecos82]

> On Jan. 18, 2012, 2:38 p.m., Matt Jordan wrote:
> > http://svn.asterisk.org/svn/asterisk/trunk/apps/app_mixmonitor.c, line 800
> > <https://reviewboard.asterisk.org/r/1643/diff/5/?file=23193#file23193line800>
> >
> >     Is this no longer needed?

It is required to detach audiohook but we cannot do it with ast_audiohook_detach_source because it has no control on the concrete audiohook which is being detached from the channel. Instead we need to look for the concrete audiohook we are stopping and detach it (this is done in lines 813-814).


- telecos82


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1643/#review5212
-----------------------------------------------------------


On Jan. 17, 2012, 5:26 a.m., telecos82 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1643/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2012, 5:26 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently, if there are several MixMonitor started on a channel, there is no way to specify which MixMonitor to stop with StopMixMonitor. With this patch we will allow this. One limitation of current implementation was that mixmonitor datastore was not identified with a uid so there was no way to identify a concrete MixMonitor. Furthermore, when retrieving audiohook to dettach from channel, there was no control on which audiohook to dettach, it always got first audiohook found of type mixmonitor_spy_type. With this patch we are identifying MixMonitor datastore by the filename asociated to it, and dettaching the concrete audiohook contained on datastore. Furthermore a new CLI command "mixmonitor list <channel_name>" to help querying active mixmonitors on a channel.
> 
> 
> This addresses bug ASTERISK-19096.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19096
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/trunk/apps/app_mixmonitor.c 348737 
> 
> Diff: https://reviewboard.asterisk.org/r/1643/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> telecos82
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120119/8e90442d/attachment.htm>