[asterisk-dev] [Code Review]: get_pai function doesnt work correct, using reqresp_parser functions solves this problem

[Matt Jordan]

> On Jan. 17, 2012, 9:16 a.m., Paul Belanger wrote:
> > Any chance for some unit tests?  Seems like a good one for it.

There are unit tests covering the parsing methods in reqresp_parser, which is another reason to use those instead of rolling your own.  Adding unit tests specifically for get_pai would be tricky, as it interacts with both a sip_pvt and an ast_channel, which would require mock objects for both.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1673/#review5194
-----------------------------------------------------------


On Jan. 17, 2012, 8:11 a.m., schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1673/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2012, 8:11 a.m.)
> 
> 
> Review request for Asterisk Developers and wdoekes.
> 
> 
> Summary
> -------
> 
> the get_pai function in chan_sip.c fails to parse a PAI header with a display name set but without ". There are also some wrong char pointer initialisations used.
> By replacing the self made header parsing functions by reqresp_parser functions everything works fine.
> 
> 
> Diffs
> -----
> 
>   team/schmidts/unleash-the-beast/channels/chan_sip.c 350974 
> 
> Diff: https://reviewboard.asterisk.org/r/1673/diff
> 
> 
> Testing
> -------
> 
> tested several different P-Asserted-Identity Headers with display name or without.
> 
> 
> Thanks,
> 
> schmidts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120117/80b4bf6a/attachment-0001.htm>