[asterisk-dev] [Code Review] avoid cppcheck warnings

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1651/#review5203
-----------------------------------------------------------

Ship it!


Looks good to go, if you fix these little items ;)


trunk/addons/chan_mobile.c
<https://reviewboard.asterisk.org/r/1651/#comment9690>

    The manual says 0 and -1. Suggest doing < 0 instead.



trunk/apps/app_chanspy.c
<https://reviewboard.asterisk.org/r/1651/#comment9691>

    Unnecessary parens around ast_waitfor.



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1651/#comment9692>

    Unnecessary parens around 2nd pbx_builting_getvar_helper.



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1651/#comment9693>

    Adding spaces here was unnecessary. It looked fine as it was.



trunk/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/1651/#comment9694>

    Space between ( and init_ shall go.



trunk/funcs/func_env.c
<https://reviewboard.asterisk.org/r/1651/#comment9695>

    Should probably have kept the readlen= and did fbuf + readlen instead of fbuf + sizeof(fbuf) and this has more implications.
    
    But I see this is already handled differently in other areas...
    
                            if (fread(fbuf, 1, sizeof(fbuf), ff) && !feof(ff)) {  <-- that's a different bug, on line 639.. looks like we're missing a "< sizeof(fbuf)"
                                    ast_log(LOG_ERROR, "Short read?!!\n");
                                    fclose(ff);
                                    return -1;
                            }
    
    I think aborting is the right way. fread shouldn't do short reads according to the manual.



trunk/main/ast_expr2f.c
<https://reviewboard.asterisk.org/r/1651/#comment9696>

    Spaces:
    
    for (i = 0; i < (int)...


- wdoekes


On Jan. 12, 2012, 8:08 p.m., junky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1651/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2012, 8:08 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> By running cppcheck 1.52, i realized there was many errors/warnings.
> 
> This patch fixes many of those.
> 
> 
> Diffs
> -----
> 
>   trunk/addons/chan_mobile.c 349670 
>   trunk/addons/chan_ooh323.c 349670 
>   trunk/apps/app_alarmreceiver.c 349670 
>   trunk/apps/app_chanspy.c 349670 
>   trunk/apps/app_disa.c 349670 
>   trunk/apps/app_minivm.c 349670 
>   trunk/apps/app_osplookup.c 349670 
>   trunk/apps/app_queue.c 349670 
>   trunk/apps/app_voicemail.c 349670 
>   trunk/channels/chan_dahdi.c 349670 
>   trunk/channels/chan_iax2.c 349670 
>   trunk/channels/chan_misdn.c 349670 
>   trunk/channels/chan_skinny.c 349670 
>   trunk/channels/chan_usbradio.c 349670 
>   trunk/formats/format_h263.c 349670 
>   trunk/funcs/func_env.c 349670 
>   trunk/funcs/func_odbc.c 349670 
>   trunk/funcs/func_strings.c 349670 
>   trunk/main/acl.c 349670 
>   trunk/main/ast_expr2.c 349670 
>   trunk/main/ast_expr2f.c 349670 
>   trunk/main/pbx.c 349670 
>   trunk/main/udptl.c 349670 
>   trunk/res/res_phoneprov.c 349670 
>   trunk/utils/astman.c 349670 
> 
> Diff: https://reviewboard.asterisk.org/r/1651/diff
> 
> 
> Testing
> -------
> 
> still compile fine.
> Shouldn't have any impact on the code execution.
> 
> 
> Thanks,
> 
> junky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120117/db221f13/attachment-0001.htm>