[asterisk-dev] [Code Review] get_pai function doesnt work correct, using reqresp_parser functions solves this problem

[schmidts]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1673/
-----------------------------------------------------------

(Updated Jan. 17, 2012, 6:47 a.m.)


Review request for Asterisk Developers and wdoekes.


Changes
-------

added free of cid_num and cid_name cause they got allocated by get_name_and_number function.
and wdoekes comments


Summary
-------

the get_pai function in chan_sip.c fails to parse a PAI header with a display name set but without ". There are also some wrong char pointer initialisations used.
By replacing the self made header parsing functions by reqresp_parser functions everything works fine.


Diffs (updated)
-----

  team/schmidts/unleash-the-beast/channels/chan_sip.c 350974 

Diff: https://reviewboard.asterisk.org/r/1673/diff


Testing
-------

tested several different P-Asserted-Identity Headers with display name or without.


Thanks,

schmidts

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120117/baa62dca/attachment.htm>