[asterisk-dev] [Code Review] fix parallel build problem with make -j

Paul Belanger reviewboard at asterisk.org
Mon Jan 16 13:10:59 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1660/#review5183
-----------------------------------------------------------

Ship it!


- Paul


On Jan. 9, 2012, 2:57 p.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1660/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2012, 2:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> make -j fails because cleantest is ran during the rest of the build, sometimes causing already built files to get removed again.
> 
> Filed against trunk because parallel building seems unsupported and is therefore a new feature.
> 
> (I'm not real fond of the workaround, but I don't know how to solve the dependency in a cleaner way with make. Suggestions are welcome.)
> 
> 
> This addresses bug ASTERISK-18751.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18751
> 
> 
> Diffs
> -----
> 
>   trunk/Makefile 350180 
> 
> Diff: https://reviewboard.asterisk.org/r/1660/diff
> 
> 
> Testing
> -------
> 
> After the patch I got a succesful build when doing:
> 
> $ echo crap > .lastclean && make -j4 -w all
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120116/dd580fa0/attachment.htm>


More information about the asterisk-dev mailing list