[asterisk-dev] [Code Review] Make the FollowMe application optionally update the connected line information when the accepting endpoint is bridged.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1656/#review5155
-----------------------------------------------------------

Ship it!


Looks good!

- Mark


On Jan. 9, 2012, 4:36 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1656/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2012, 4:36 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Like Dial and Queue, FollowMe needs to deal with AST_CONTROL_CONNECTED_LINE information so when the parties are initially bridged, the connected line information will be correct.
> 
> Added the 'I' option just like the app_dial and app_queue 'I' option.
> 
> 
> This addresses bug ASTERISK-18969.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18969
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/CHANGES 350222 
>   /branches/1.8/apps/app_dial.c 350222 
>   /branches/1.8/apps/app_followme.c 350222 
> 
> Diff: https://reviewboard.asterisk.org/r/1656/diff
> 
> 
> Testing
> -------
> 
> Tested with and without the new FollowMe 'I' option.  Connected line is updated or blocked in a similar manner to app_dial and app_queue.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120110/6a6b4162/attachment.htm>