[asterisk-dev] [Code Review] Allow specifying which MixMonitor to stop

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1643/#review5119
-----------------------------------------------------------



http://svn.asterisk.org/svn/asterisk/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/1643/#comment9527>

    You are using spaces here instead of tabs.



http://svn.asterisk.org/svn/asterisk/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/1643/#comment9528>

    Brace is out of alignment.



http://svn.asterisk.org/svn/asterisk/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/1643/#comment9529>

    red blob.  You have some EOL white space.



http://svn.asterisk.org/svn/asterisk/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/1643/#comment9530>

    I think you forgot to change the manager stop action to reflect the use if IDs instead of file names.


- jrose


On Dec. 27, 2011, 8:39 a.m., telecos82 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1643/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2011, 8:39 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently, if there are several MixMonitor started on a channel, there is no way to specify which MixMonitor to stop with StopMixMonitor. With this patch we will allow this. One limitation of current implementation was that mixmonitor datastore was not identified with a uid so there was no way to identify a concrete MixMonitor. Furthermore, when retrieving audiohook to dettach from channel, there was no control on which audiohook to dettach, it always got first audiohook found of type mixmonitor_spy_type. With this patch we are identifying MixMonitor datastore by the filename asociated to it, and dettaching the concrete audiohook contained on datastore. Furthermore a new CLI command "mixmonitor list <channel_name>" to help querying active mixmonitors on a channel.
> 
> 
> This addresses bug ASTERISK-19096.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19096
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/trunk/apps/app_mixmonitor.c 348737 
> 
> Diff: https://reviewboard.asterisk.org/r/1643/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> telecos82
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120106/1efd6822/attachment-0001.htm>