[asterisk-dev] [Code Review]: avoid cppcheck warnings
junky
reviewboard at asterisk.org
Thu Jan 5 20:13:13 CST 2012
> On Jan. 5, 2012, 6:42 p.m., rmudgett wrote:
> > trunk/main/pbx.c, line 4094
> > <https://reviewboard.asterisk.org/r/1651/diff/1/?file=22552#file22552line4094>
> >
> > Add spaces around = per guidelines.
added whitespaces.
- junky
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1651/#review5115
-----------------------------------------------------------
On Jan. 5, 2012, 8:12 p.m., junky wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1651/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2012, 8:12 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> By running cppcheck 1.52, i realized there was many errors/warnings.
>
> This patch fixes many of those.
>
>
> Diffs
> -----
>
> trunk/addons/chan_mobile.c 349670
> trunk/addons/chan_ooh323.c 349670
> trunk/apps/app_chanspy.c 349670
> trunk/apps/app_minivm.c 349670
> trunk/apps/app_osplookup.c 349670
> trunk/apps/app_queue.c 349670
> trunk/apps/app_voicemail.c 349670
> trunk/funcs/func_env.c 349670
> trunk/funcs/func_odbc.c 349670
> trunk/funcs/func_strings.c 349670
> trunk/main/pbx.c 349670
>
> Diff: https://reviewboard.asterisk.org/r/1651/diff
>
>
> Testing
> -------
>
> still compile fine.
> Shouldn't have any impact on the code execution.
>
>
> Thanks,
>
> junky
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120106/470afe05/attachment.htm>
More information about the asterisk-dev
mailing list