[asterisk-dev] [Code Review]: avoid cppcheck warnings

[junky]

> On Jan. 5, 2012, 10:24 a.m., Tilghman Lesher wrote:
> > trunk/addons/chan_ooh323.c, line 4188
> > <https://reviewboard.asterisk.org/r/1651/diff/1/?file=22543#file22543line4188>
> >
> >     Kill redspot.

removed.


> On Jan. 5, 2012, 10:24 a.m., Tilghman Lesher wrote:
> > trunk/apps/app_chanspy.c, lines 975-976
> > <https://reviewboard.asterisk.org/r/1651/diff/1/?file=22544#file22544line975>
> >
> >     You should probably just use the "num" result here instead of redoing the calculation.  Also, add braces while you're here.

fixed.


> On Jan. 5, 2012, 10:24 a.m., Tilghman Lesher wrote:
> > trunk/apps/app_queue.c, line 4866
> > <https://reviewboard.asterisk.org/r/1651/diff/1/?file=22547#file22547line4866>
> >
> >     If we're not using the results of this second call, why bother retrieving it at all?

removed, since we're not using it anyways.


- junky


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1651/#review5106
-----------------------------------------------------------


On Jan. 4, 2012, 11:10 p.m., junky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1651/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2012, 11:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> By running cppcheck 1.52, i realized there was many errors/warnings.
> 
> This patch fixes many of those.
> 
> 
> Diffs
> -----
> 
>   trunk/addons/chan_mobile.c 349670 
>   trunk/addons/chan_ooh323.c 349670 
>   trunk/apps/app_chanspy.c 349670 
>   trunk/apps/app_minivm.c 349670 
>   trunk/apps/app_osplookup.c 349670 
>   trunk/apps/app_queue.c 349670 
>   trunk/apps/app_voicemail.c 349670 
>   trunk/funcs/func_env.c 349670 
>   trunk/funcs/func_odbc.c 349670 
>   trunk/funcs/func_strings.c 349670 
>   trunk/main/pbx.c 349670 
> 
> Diff: https://reviewboard.asterisk.org/r/1651/diff
> 
> 
> Testing
> -------
> 
> still compile fine.
> Shouldn't have any impact on the code execution.
> 
> 
> Thanks,
> 
> junky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120106/464f6bee/attachment-0001.htm>