[asterisk-dev] [Code Review] dsp.c refactor section of dtmf_detect

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1130/#review5114
-----------------------------------------------------------

Ship it!


Been playing with this for a good bit of the day.  It doesn't break anything in my normal DTMF tests, though I have to acknowledge I lack the resources to reproduce the bug.  I'm going to go ahead and commit the patch as is, minus the additional debug statements since there are already DTMF logs which detail all of the information purveyed here.

- jrose


On March 2, 2011, 5:47 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1130/
> -----------------------------------------------------------
> 
> (Updated March 2, 2011, 5:47 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In the process of trying to get DISA working with mobile phones, finished up cleaning a section of dtmf_detect.
> 
> 
> This addresses bug 18904.
>     https://issues.asterisk.org/jira/browse/18904
> 
> 
> Diffs
> -----
> 
>   trunk/main/dsp.c 309081 
> 
> Diff: https://reviewboard.asterisk.org/r/1130/diff
> 
> 
> Testing
> -------
> 
> Tested on 2 systems.
> system 1: On analog FXS connected phone, verified dtmf detection, is still valid.
> 
> system 2:. using callfile to call mobile, and then use DISA to sucessfully dial every time.
> 
> System 2: Debug logs (with dateformat=%F %T.%3q), show false triggers, with events triggered at appropriate times, 40ms.
> [2011-03-03 00:14:39.023] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.023] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.043] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.083] DEBUG[18627] dsp.c: DTMF BEG digit='2' len=0
> [2011-03-03 00:14:39.083] DEBUG[18627] chan_dahdi.c: Begin DTMF digit: 0x32 '2' on DAHDI/i1/021XXXXXX-1
> [2011-03-03 00:14:39.163] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.183] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.203] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.223] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.303] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.323] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.743] DEBUG[18627] dsp.c: DTMF EDGE
> [2011-03-03 00:14:39.783] DEBUG[18627] dsp.c: DTMF END digit='2' len=4590
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120105/97b66c64/attachment.htm>