[asterisk-dev] [Code Review]: avoid cppcheck warnings

[Matt Jordan]

> On Jan. 5, 2012, 10:54 a.m., Mark Michelson wrote:
> > trunk/apps/app_chanspy.c, lines 975-976
> > <https://reviewboard.asterisk.org/r/1651/diff/1/?file=22544#file22544line975>
> >
> >     Instead of getting rid of "num" change line 975 to use "num" as its second argument.
> >     
> >     Also, I'm not a fan of using atoi() in this way. atoi() will return 0 if the input cannot be parsed as a number OR if the number is 0. strtol() is better for this sort of thing.

strtol returns a 0 in the case of a conversion error as well.  You could check the errno after the conversion, but in general, sscanf is the preferred option.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1651/#review5107
-----------------------------------------------------------


On Jan. 4, 2012, 11:10 p.m., junky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1651/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2012, 11:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> By running cppcheck 1.52, i realized there was many errors/warnings.
> 
> This patch fixes many of those.
> 
> 
> Diffs
> -----
> 
>   trunk/addons/chan_mobile.c 349670 
>   trunk/addons/chan_ooh323.c 349670 
>   trunk/apps/app_chanspy.c 349670 
>   trunk/apps/app_minivm.c 349670 
>   trunk/apps/app_osplookup.c 349670 
>   trunk/apps/app_queue.c 349670 
>   trunk/apps/app_voicemail.c 349670 
>   trunk/funcs/func_env.c 349670 
>   trunk/funcs/func_odbc.c 349670 
>   trunk/funcs/func_strings.c 349670 
>   trunk/main/pbx.c 349670 
> 
> Diff: https://reviewboard.asterisk.org/r/1651/diff
> 
> 
> Testing
> -------
> 
> still compile fine.
> Shouldn't have any impact on the code execution.
> 
> 
> Thanks,
> 
> junky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120105/60f3afd0/attachment.htm>