[asterisk-dev] [Code Review] Support 'deaf' participants in ConfBridge

fabled reviewboard at asterisk.org
Tue Jan 3 08:36:07 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1645/
-----------------------------------------------------------

(Updated Jan. 3, 2012, 8:36 a.m.)


Review request for Asterisk Developers.


Changes
-------

Updated according to feedback. Compile tested for now only, will do more testing soon.

Should the silence generation be merged with main/channel.c:silence_generator_generate() as they are about identical in code. They could also share a global static buffer (filled with zeroes) so we avoid runtime memset().


Summary
-------

Support 'deaf' participants in ConfBridge


This addresses bug ASTERISK-19109.
    https://issues.asterisk.org/jira/browse/ASTERISK-19109


Diffs (updated)
-----

  /trunk/CHANGES 349410 
  /trunk/apps/app_confbridge.c 349410 
  /trunk/apps/confbridge/conf_config_parser.c 349410 
  /trunk/apps/confbridge/include/confbridge.h 349410 
  /trunk/bridges/bridge_multiplexed.c 349410 
  /trunk/bridges/bridge_simple.c 349410 
  /trunk/bridges/bridge_softmix.c 349410 
  /trunk/configs/confbridge.conf.sample 349410 
  /trunk/include/asterisk/bridging_features.h 349410 
  /trunk/include/asterisk/bridging_technology.h 349410 
  /trunk/main/bridging.c 349410 

Diff: https://reviewboard.asterisk.org/r/1645/diff


Testing
-------


Thanks,

fabled

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120103/c2bfa898/attachment-0001.htm>


More information about the asterisk-dev mailing list