[asterisk-dev] [Code Review] Fix case-sensitivity for device-specific event subscriptions and CCSS

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1780/#review5683
-----------------------------------------------------------



trunk/main/event.c
<https://reviewboard.asterisk.org/r/1780/#comment10394>

    Unlike ast_strdup(), ast_strdupa() will crash and burn if passed a NULL pointer. Given that the original code makes sure to check if str is non-NULL before calling strcmp(), it makes me believe that str has the possibility of being NULL. So the ast_strdupa(str) call needs to be done conditionally.


- Mark


On Feb. 29, 2012, 10:55 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1780/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2012, 10:55 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This change fixes case-sensitivity for device-specific subscriptions such that the technology identifier is case-insensitive while the remainder of the device string is still case-sensitive.  This should also preserve the original case of the device string as passed in to the event system.  CCSS is the only feature affected as it is the only consumer of device-specific event subscriptions.
> 
> The second part of this patch addresses similar case-sensitivity issues within CCSS itself that prevented it from functioning correctly after the fix to the events system.
> 
> 
> This addresses bug ASTERISK-19422.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19422
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/strings.h 357316 
>   trunk/main/ccss.c 357316 
>   trunk/main/event.c 357316 
>   trunk/tests/test_event.c 357316 
> 
> Diff: https://reviewboard.asterisk.org/r/1780/diff
> 
> 
> Testing
> -------
> 
> Added unit tests for the event system changes and used the pending CCSS test to verify that CCSS functioned correctly when cases were mixed.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120301/20de9e7f/attachment-0001.htm>