[asterisk-dev] [Code Review] Add F option from dial to app_queue

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1785/#review5682
-----------------------------------------------------------



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1785/#comment10390>

    No need for trailing comma if it must be the last one.



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1785/#comment10391>

    Unnecessary space.



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1785/#comment10389>

    Cut-n-paste error.  CALLER/callee mismatch.



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1785/#comment10393>

    Call can fail so you should not run a pbx.



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1785/#comment10392>

    You should not start the pbx after a hangup because peer is invalid.


- rmudgett


On Feb. 29, 2012, 3:25 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1785/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2012, 3:25 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and rmudgett.
> 
> 
> Summary
> -------
> 
> This adds the F option from dial to queue.  The idea is pretty simple.
> 
> If F is enabled, if the caller has connected to a queue member and hangs up, the queue member who was called will stay active and go to the indicated context/extension/priority.
> 
> If no arguments are set for F, then the called member will jump to the next priority as with Dial.
> 
> 
> This addresses bug ASTERISK-19283.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19283
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_queue.c 357541 
> 
> Diff: https://reviewboard.asterisk.org/r/1785/diff
> 
> 
> Testing
> -------
> 
> exten => 013,1,Answer()
> exten => 013,2,Set(_crunchbar=chocorice)
> exten => 013,n,NoOp(_crunchbar=${crunchbar})
> exten => 013,n,Queue(markq,F())
> exten => 013,n,Playback(tt-weasels)
> exten => 013,n,NoOp(_crunchbar=${crunchbar})
> 
> Tested to see if the member would be directed to Playback(tt-weasels) and then properly display the crunchbar variable which was documented as being supposed to be copied.
> 
> Also:
> 
> exten => 014,1,Answer()
> exten => 014,n,Set(_licorice=yuck)
> exten => 014,n,NoOp(_licorice=${licorice})
> exten => 014,n,Queue(markq,F(queuetestcontext^001^1))
> exten => 014,n,NoOp(Goldfishes \(love you\))
> 
> [queuetestcontext]
> exten => 001,1,NoOp()
> exten => 001,n,Playback(tt-weasels)
> exten => 001,n,NoOp(_licorice=${licorice})
> 
> To make sure it worked with all the arguments for F.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120301/48ff3bab/attachment.htm>