[asterisk-dev] [Code Review] Remove chan_usbradio and app_rpt.

Russell Bryant russell at russellbryant.net
Tue Feb 28 21:02:42 CST 2012


It's a good goal to have, but I think this ship sailed a long time ago.
I'm sure the Asterisk maintainers would be happy to talk about merging it
back in if that code ever got back to the point where it can work with the
latest versions of everything.

--
Russell Bryant


On Tue, Feb 28, 2012 at 6:44 PM, Steve Totaro <
stotaro at totarotechnologies.com> wrote:

> On topic,
>
> Ship it.
>
> Obviously it is a loss to the Asterisk community and Digium but oh well.
>
> Just trying to help keep an extremely beneficial app in Asterisk Code Base.
>
> Thanks,
> Steve Totaro
>
>
> On Tue, Feb 28, 2012 at 6:40 PM, Steve Totaro <
> stotaro at totarotechnologies.com> wrote:
>
>> Sean,
>>
>> What's up buddy, long time no see.
>>
>> I am glad I turned you onto Asterisk back in the day.
>>
>> Do you still talk to Joe Rensin?  I heard the Feds finally shut him down.
>>  I was in Iraq for a while and out of the loop.
>>
>> Thanks,
>> Steve Totaro
>>
>> On Tue, Feb 28, 2012 at 5:11 PM, Sean Bright <reviewboard at asterisk.org>wrote:
>>
>>>    This is an automatically generated e-mail. To reply, visit:
>>> https://reviewboard.asterisk.org/r/1764/
>>>
>>> Ship it!
>>>
>>> Hear, hear!
>>>
>>>
>>> - Sean
>>>
>>> On February 22nd, 2012, 10:01 a.m., Russell Bryant wrote:
>>>   Review request for Asterisk Developers.
>>> By Russell Bryant.
>>>
>>> *Updated Feb. 22, 2012, 10:01 a.m.*
>>> Description
>>>
>>> This patch removes app_rpt and chan_usbradio from trunk.  I don't have a problem at all with these modules being in trunk, but they do not appear to be maintained in this repository.  One of the primary radio guys said in #asterisk-dev the other day that plenty of people use this stuff, but that fixes haven't been sent back up to this repo in years.  It seems harmful to have an out-of-date copy of this code here.
>>>
>>>   Testing
>>>
>>> ran configure and make.
>>>
>>>   Diffs
>>>
>>>    - /trunk/apps/app_rpt.c (356258)
>>>    - /trunk/build_tools/menuselect-deps.in (356258)
>>>    - /trunk/channels/chan_usbradio.c (356258)
>>>    - /trunk/channels/xpmr/sinetabx.h (356258)
>>>    - /trunk/channels/xpmr/xpmr.h (356258)
>>>    - /trunk/channels/xpmr/xpmr.c (356258)
>>>    - /trunk/channels/xpmr/xpmr_coef.h (356258)
>>>    - /trunk/configure (UNKNOWN)
>>>    - /trunk/configure.ac (356258)
>>>    - /trunk/include/asterisk/autoconfig.h.in (356258)
>>>    - /trunk/makeopts.in (356258)
>>>
>>> View Diff <https://reviewboard.asterisk.org/r/1764/diff/>
>>>
>>> --
>>> _____________________________________________________________________
>>> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>>>
>>> asterisk-dev mailing list
>>> To UNSUBSCRIBE or update options visit:
>>>   http://lists.digium.com/mailman/listinfo/asterisk-dev
>>>
>>
>>
>
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>   http://lists.digium.com/mailman/listinfo/asterisk-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120228/9d8f2650/attachment.htm>


More information about the asterisk-dev mailing list