[asterisk-dev] [Code Review] copy accountcode to accountcode, not peeraccount in app_dial

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1775/#review5672
-----------------------------------------------------------

Ship it!


As far as I can tell, the change to set peeraccount was wrong.  All the other places that create an outgoing channel set the accountcode from the initiating channel.

- rmudgett


On Feb. 28, 2012, 2:51 p.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1775/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2012, 2:51 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> r203638 | russell | 2009-06-26 17:28:53 +0200 (Fri, 26 Jun 2009) | 14 lines
> added the CEL event logging subsystem.
> 
> When this got added to trunk, the bug of ASTERISK-19384 started to appear.
> 
> jamicque spotted the difference between peeraccount and account in app_dial:
> 
> -               ast_string_field_set(tc, accountcode, chan->accountcode);
> +               if (!ast_strlen_zero(chan->accountcode)) {
> +                       ast_string_field_set(tc, peeraccount, chan->accountcode);
> +               }
> 
> He attached accountcode.patch (License #6033) to the bugreport which changes that peeraccount into accountcode.
> 
> Was this a typo? Or was this meant to be changed?
> 
> If we apply the patch, the expected CDR behaviour with regards to the accountcode is restored.
> 
> 
> This addresses bug ASTERISK-19384.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19384
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_dial.c 357402 
> 
> Diff: https://reviewboard.asterisk.org/r/1775/diff
> 
> 
> Testing
> -------
> 
> 10 out of 10 of the testsuite cdr tests that run on my system still run successfully after applying the patch.
> 
> And now the 11th test (r1765) runs succesfully some of the time. (Only sometimes because of the undefined CDR order, this has to be fixed in the test.)
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120229/c5748d53/attachment.htm>