[asterisk-dev] [Code Review] Add tests for connected line, redirecting, and csss to test new gosub calls

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1761/#review5643
-----------------------------------------------------------



asterisk/trunk/lib/python/asterisk/SimpleTestCase.py
<https://reviewboard.asterisk.org/r/1761/#comment10307>

    can be dropped.  TestCase defines this.



asterisk/trunk/lib/python/asterisk/SimpleTestCase.py
<https://reviewboard.asterisk.org/r/1761/#comment10308>

    I'd rather see the start_asterisk / stop_asterisk outside the class. To keep it similar to the other tests.
    
    Then this function can be removed, and just we the run() function.



asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1761/#comment10310>

    Echo() ?



asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1761/#comment10311>

    Rather see something else here



asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1761/#comment10312>

    same



asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1761/#comment10313>

    echo()?



asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1761/#comment10314>

    can be removed



asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1761/#comment10315>

    same



asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/sip.conf
<https://reviewboard.asterisk.org/r/1761/#comment10316>

    same



asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/sip.conf
<https://reviewboard.asterisk.org/r/1761/#comment10317>

    same



asterisk/trunk/tests/channels/SIP/generic_ccss/run-test
<https://reviewboard.asterisk.org/r/1761/#comment10309>

    not needed


- Paul


On Feb. 24, 2012, 4:35 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1761/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2012, 4:35 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add tests for the existing macro and new gosub calls in relation to connected line, redirecting, and ccss.
> 
> 
> This addresses bug SWP-4254.
>     https://issues.asterisk.org/jira/browse/SWP-4254
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/redirecting/tests.yaml PRE-CREATION 
>   asterisk/trunk/tests/tests.yaml 3064 
>   asterisk/trunk/tests/redirecting/subroutine/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/tests.yaml 3064 
>   asterisk/trunk/tests/connected_line/macro/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/connected_line/macro/run-test PRE-CREATION 
>   asterisk/trunk/tests/connected_line/macro/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/connected_line/subroutine/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/connected_line/subroutine/run-test PRE-CREATION 
>   asterisk/trunk/tests/connected_line/subroutine/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/connected_line/tests.yaml PRE-CREATION 
>   asterisk/trunk/tests/redirecting/macro/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/redirecting/macro/run-test PRE-CREATION 
>   asterisk/trunk/tests/redirecting/macro/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/redirecting/subroutine/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/redirecting/subroutine/run-test PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/run-test PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/lib/python/asterisk/SimpleTestCase.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1761/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120225/e8797575/attachment-0001.htm>