[asterisk-dev] [Code Review]: Add ability to clone ao2 containers.

[Kevin Fleming]

> On Feb. 15, 2012, 9:13 p.m., Russell Bryant wrote:
> > I think the documentation should strongly discourage the use of these functions unless they are absolutely necessary.  It's fairly expensive (a malloc() per item in the container).
> 
> Matt Jordan wrote:
>     In Richard's defense, this is (I think) just as costly as using a OBJ_MULTIPLE iterator.  This mechanism at least tells you that you are cloning the container, which somewhat implies that it isn't going to be a cheap operation.

And at least by providing an API for it, if the implementation can be improved in the future, that can be done transparently.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1746/#review5522
-----------------------------------------------------------


On Feb. 24, 2012, 4:50 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1746/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2012, 4:50 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Occasionally there is a need to put all objects in one container also into another container.
> 
> Some reasons you might need to do this:
> 1) You need to reconfigure a container.   You would do this by creating a new container with the new configuration and ao2_container_dup the old container into it.  Then replace the old container with the new.  Then destroy the old container.
> 
> 2) You need the contents of a container to remain stable while operating on all of the objects.  You would do this by creating a cloned container of the original with ao2_container_clone.  The cloned container is a snapshot of the objects at the time of the cloning.  When done, just destroy the cloned container.
> 
> 
> Diffs
> -----
> 
>   /trunk/tests/test_astobj2.c 356735 
>   /trunk/include/asterisk/astobj2.h 356735 
>   /trunk/main/astobj2.c 356735 
> 
> Diff: https://reviewboard.asterisk.org/r/1746/diff
> 
> 
> Testing
> -------
> 
> Added unit testing code to test the new ao2_container_clone and ao2_container_dup functions.
> 
> Tests still pass.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120224/5717c8d8/attachment.htm>