[asterisk-dev] [Code Review] Resolve odbc segfaults by adding shared locks around usage of odbc handle in res_odbc

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1719/
-----------------------------------------------------------

(Updated Feb. 24, 2012, 3:40 p.m.)


Review request for Asterisk Developers, Mark Michelson, Tilghman Lesher, rmudgett, and wdoekes.


Changes
-------

Ok, that last one was a bit of a failure.  This fixes it up.

There is also a need to add some of these extra locks to the mutex lock in 1.8 and 10.  So, in a little while I'll add another patch to go with those.


Summary
-------

This is a continuation of wdoekes patch seen in https://reviewboard.asterisk.org/r/1622/
This adds Tilghman Lesher's suggested changes.


This addresses bug ASTERISK-19011.
    https://issues.asterisk.org/jira/browse/ASTERISK-19011


Diffs (updated)
-----

  /trunk/include/asterisk/res_odbc.h 356735 
  /trunk/res/res_odbc.c 356735 

Diff: https://reviewboard.asterisk.org/r/1719/diff


Testing
-------

I started by confirming that the segfault could be easily reproduced with wdoekes' setup mentioned in the issue report.
After finishing the changes to the patch, I confirmed that following the same steps no longer produced the segfault, undid the patch to double check that I was doing it right, and then decided it was safe to post this review.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120224/d13bc49f/attachment.htm>