[asterisk-dev] [Code Review] Resolve odbc segfaults by adding shared locks around usage of odbc handle in res_odbc

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1719/
-----------------------------------------------------------

(Updated Feb. 24, 2012, 2:02 p.m.)


Review request for Asterisk Developers, Mark Michelson, Tilghman Lesher, rmudgett, and wdoekes.


Changes
-------

Some of Richard's comments, Also converted from using rwlocks to mutex locks... and then later to ao2locks.  And now ao2rwlocks might be on the table later, so possibly anticipating having to go full circle.


Summary
-------

This is a continuation of wdoekes patch seen in https://reviewboard.asterisk.org/r/1622/
This adds Tilghman Lesher's suggested changes.


This addresses bug ASTERISK-19011.
    https://issues.asterisk.org/jira/browse/ASTERISK-19011


Diffs (updated)
-----

  /branches/1.8/res/res_odbc.c 356521 

Diff: https://reviewboard.asterisk.org/r/1719/diff


Testing
-------

I started by confirming that the segfault could be easily reproduced with wdoekes' setup mentioned in the issue report.
After finishing the changes to the patch, I confirmed that following the same steps no longer produced the segfault, undid the patch to double check that I was doing it right, and then decided it was safe to post this review.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120224/cd0c7341/attachment-0001.htm>