[asterisk-dev] [Code Review] fix compiling warnings for chan_ooh323

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1767/#review5607
-----------------------------------------------------------



branches/1.8/addons/ooh323cDriver.c
<https://reviewboard.asterisk.org/r/1767/#comment10259>

    Returning here changes the behavior of this function.  If res is unused, then - from the perspective of only fixing a compiler warning, and not change the semantics of this portion of the code - you shouldn't check the return value of this call.
    
    That being said, Alexander Anikin (may123) is the man when it comes to chan_ooh323, so you should probably ask him.
    
    


- Matt


On Feb. 22, 2012, 11:15 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1767/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2012, 11:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I spend sometime cleaning up the compiler warnings, some big issues revolve around the fact that read() and write() return values are ignored.  Not safe from what I read.  Any suggestions / recommendations if I have handled it right?
> 
> 
> Diffs
> -----
> 
>   branches/1.8/addons/ooh323c/src/memheap.c 356432 
>   branches/1.8/addons/ooh323c/src/ooCapability.c 356432 
>   branches/1.8/addons/ooh323c/src/ooSocket.c 356432 
>   branches/1.8/addons/ooh323c/src/ooTimer.c 356432 
>   branches/1.8/addons/ooh323c/src/ooq931.c 356432 
>   branches/1.8/addons/ooh323c/src/perutil.c 356432 
>   branches/1.8/addons/ooh323cDriver.c 356432 
> 
> Diff: https://reviewboard.asterisk.org/r/1767/diff
> 
> 
> Testing
> -------
> 
> compiling testing on development box.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120223/631e9316/attachment-0001.htm>