[asterisk-dev] [Code Review] fix compiling warnings for chan_ooh323

Paul Belanger reviewboard at asterisk.org
Wed Feb 22 23:15:38 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1767/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

I spend sometime cleaning up the compiler warnings, some big issues revolve around the fact that read() and write() return values are ignored.  Not safe from what I read.  Any suggestions / recommendations if I have handled it right?


Diffs
-----

  branches/1.8/addons/ooh323c/src/memheap.c 356432 
  branches/1.8/addons/ooh323c/src/ooCapability.c 356432 
  branches/1.8/addons/ooh323c/src/ooSocket.c 356432 
  branches/1.8/addons/ooh323c/src/ooTimer.c 356432 
  branches/1.8/addons/ooh323c/src/ooq931.c 356432 
  branches/1.8/addons/ooh323c/src/perutil.c 356432 
  branches/1.8/addons/ooh323cDriver.c 356432 

Diff: https://reviewboard.asterisk.org/r/1767/diff


Testing
-------

compiling testing on development box.


Thanks,

Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120223/4ee2d851/attachment-0001.htm>


More information about the asterisk-dev mailing list