[asterisk-dev] [Code Review]: fix compile warnings with app_rpt

[Paul Belanger]

> On Feb. 22, 2012, 2:08 p.m., Matt Jordan wrote:
> > I hate clicking ship it on this, because app_rpt is (from the brief inspection I just did) quite frankly a mess, and I haven't tested the diff you've posted.  I'm not sure what the testing done was - 'local dev box' makes me think that it compiled and potentially loaded, but no actual usage of the module occurred.  I know the fix was here to make --enable-dev-mode work on this module, but when a module is as unused as this one, either we need to verify that it isn't any more broken then it already was, or we need to not change the module.

you are right, it is difficult to trace the original 's'.  From what I see, it's never used again.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1763/#review5590
-----------------------------------------------------------


On Feb. 22, 2012, 9:39 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1763/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2012, 9:39 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Need some help making sure this patch is correct.  See comments below
> 
> 
> Diffs
> -----
> 
>   branches/1.8/apps/app_rpt.c 356220 
> 
> Diff: https://reviewboard.asterisk.org/r/1763/diff
> 
> 
> Testing
> -------
> 
> local dev box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120222/d29e3ef3/attachment.htm>