[asterisk-dev] [Code Review] fix compile warnings with app_rpt

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1763/#review5589
-----------------------------------------------------------



branches/1.8/apps/app_rpt.c
<https://reviewboard.asterisk.org/r/1763/#comment10251>

    From the diff, it was difficult to tell if 's' got used anywhere after this (and this is yet another reason not to use single letters as variables).  If s is, then you need to at least keep strsep even if you ignore the return value - strsep will modify s (inserting a '\0' in the next occurrence of the ',') so as not to change behavior.  Otherwise, this is fine.



branches/1.8/apps/app_rpt.c
<https://reviewboard.asterisk.org/r/1763/#comment10252>

    Same finding here


- Matt


On Feb. 22, 2012, 9:39 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1763/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2012, 9:39 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Need some help making sure this patch is correct.  See comments below
> 
> 
> Diffs
> -----
> 
>   branches/1.8/apps/app_rpt.c 356220 
> 
> Diff: https://reviewboard.asterisk.org/r/1763/diff
> 
> 
> Testing
> -------
> 
> local dev box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120222/2f0ca938/attachment-0001.htm>