[asterisk-dev] [Code Review] Lightweight NAT Support Test

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1759/#review5584
-----------------------------------------------------------



/asterisk/trunk/tests/channels/SIP/lightweight_nat/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1759/#comment10218>

    udpbindaddr=127.0.0.1



/asterisk/trunk/tests/channels/SIP/lightweight_nat/run-test
<https://reviewboard.asterisk.org/r/1759/#comment10220>

    self.stop_reactor()



/asterisk/trunk/tests/channels/SIP/lightweight_nat/run-test
<https://reviewboard.asterisk.org/r/1759/#comment10217>

    can be removed, we check the reactor in TestCase



/asterisk/trunk/tests/channels/SIP/lightweight_nat/run-test
<https://reviewboard.asterisk.org/r/1759/#comment10219>

    You should be able to drop this.



/asterisk/trunk/tests/channels/SIP/lightweight_nat/run-test
<https://reviewboard.asterisk.org/r/1759/#comment10221>

    you can remove this and let the TestCase handle it.


- Paul


On Feb. 22, 2012, 10:49 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1759/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2012, 10:49 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This test tests the lightweight NAT support from another review. It is currently disabled due to finding a bug in the testsuite that prevents it from working, hacking that a bit confirms it works though.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/lightweight_nat/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/lightweight_nat/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/lightweight_nat/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/lightweight_nat/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 3055 
> 
> Diff: https://reviewboard.asterisk.org/r/1759/diff
> 
> 
> Testing
> -------
> 
> Hacked at testsuite to temporarily fix an issue I uncovered, ran test, confirmed working fine.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120222/3af8f03c/attachment.htm>