[asterisk-dev] [Code Review]: fix compile warnings with app_rpt

[Russell Bryant]

> On Feb. 22, 2012, 9:40 a.m., Paul Belanger wrote:
> > branches/1.8/apps/app_rpt.c, line 6390
> > <https://reviewboard.asterisk.org/r/1763/diff/1/?file=24490#file24490line6390>
> >
> >     This is a change in functionality, so I'm not sure it is correct.

Well, I don't think it matters much given what the line of code is doing ... that's pretty evil.


> On Feb. 22, 2012, 9:40 a.m., Paul Belanger wrote:
> > branches/1.8/apps/app_rpt.c, line 12017
> > <https://reviewboard.asterisk.org/r/1763/diff/1/?file=24490#file24490line12017>
> >
> >     again, not sure if correct

If "status" was never used, looks fine.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1763/#review5579
-----------------------------------------------------------


On Feb. 22, 2012, 9:39 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1763/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2012, 9:39 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Need some help making sure this patch is correct.  See comments below
> 
> 
> Diffs
> -----
> 
>   branches/1.8/apps/app_rpt.c 356220 
> 
> Diff: https://reviewboard.asterisk.org/r/1763/diff
> 
> 
> Testing
> -------
> 
> local dev box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120222/1e590f89/attachment.htm>