[asterisk-dev] [Code Review] Convert app_page to use app_confbridge internally

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1754/#review5557
-----------------------------------------------------------

Ship it!


Looks good to me. I certainly would like to get someone to take a second look because I never feel comfortable just giving a "ship it!" with no suggestions...it just feels like I have to have missed something :)

- Mark


On Feb. 20, 2012, 10:33 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1754/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2012, 10:33 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The Page application was originally written to use MeetMe internally but as development has progressed ConfBridge has become the new favored conference bridge application. This task was originally to change Page to use the bridging API internally but that proved to be too low level and numerous features from ConfBridge would have been duplicated. Page has therefore been rewritten to use ConfBridge internally.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_confbridge.c 355010 
>   /trunk/apps/app_page.c 355010 
>   /trunk/apps/confbridge/conf_config_parser.c 355010 
>   /trunk/apps/confbridge/include/confbridge.h 355010 
>   /trunk/include/asterisk/dial.h 355010 
>   /trunk/main/dial.c 355010 
> 
> Diff: https://reviewboard.asterisk.org/r/1754/diff
> 
> 
> Testing
> -------
> 
> Tested Paging multiple phones with different combinations of features.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120220/49421ac7/attachment.htm>