[asterisk-dev] [Code Review] sync chan_dahdi->p->outgoing with sig_XXX->p-outgoing

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1747/
-----------------------------------------------------------

(Updated Feb. 17, 2012, 2:16 p.m.)


Review request for Asterisk Developers.


Changes
-------

remove debug message.

Also in analog_set_outgoing rmove the 'return' it's a void function.
 return p->calls->set_outgoing(p->chan_pvt, is_outgoing);
becomes;
 p->calls->set_outgoing(p->chan_pvt, is_outgoing);


Summary
-------

Jeremy Pepper review https://reviewboard.asterisk.org/r/1737/ highlighted an issue where p->outgoing flag isn't in sync between chan_dahdi and sig_analog


Diffs (updated)
-----

  trunk/channels/chan_dahdi.c 353434 
  trunk/channels/sig_analog.h 353434 
  trunk/channels/sig_analog.c 353434 
  trunk/channels/sig_pri.h 353434 
  trunk/channels/sig_pri.c 353434 
  trunk/channels/sig_ss7.h 353434 
  trunk/channels/sig_ss7.c 353434 

Diff: https://reviewboard.asterisk.org/r/1747/diff


Testing
-------

sig_analog: Basic calls in and out with analog TDM800P
sig_pri and sig_ss7: compiles


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120217/55314824/attachment.htm>