[asterisk-dev] [Code Review] regression test for ASTERISK-19358 part 2 (send ACK to 200-Contact, not 1xx-Contact)

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1751/#review5534
-----------------------------------------------------------

Ship it!


Awesome - thanks for adding a test for this.  Feel free to commit when the patch that this is related to goes in.


/asterisk/trunk/tests/channels/SIP/use_contact_from_200/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1751/#comment10169>

    Blob



/asterisk/trunk/tests/channels/SIP/use_contact_from_200/run-test
<https://reviewboard.asterisk.org/r/1751/#comment10168>

    Blob



/asterisk/trunk/tests/channels/SIP/use_contact_from_200/test-config.yaml
<https://reviewboard.asterisk.org/r/1751/#comment10170>

    The fact that this test is being added due to a regression is secondary.  I'd make the summary just state what the test actually tests - in the future people will care less that it was introduced for a regression, and more about what it actually does.


- Matt


On Feb. 16, 2012, 10:48 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1751/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2012, 10:48 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Regression test for fix that belongs to:
> https://reviewboard.asterisk.org/r/1749/
> 
> 
> This addresses bug ASTERISK-19358.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19358
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/use_contact_from_200/sipp/proxy_fork_invite_no_rr.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 3036 
>   /asterisk/trunk/tests/channels/SIP/use_contact_from_200/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/use_contact_from_200/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/use_contact_from_200/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1751/diff
> 
> 
> Testing
> -------
> 
> r1749 makes the test succeed.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120216/528df3fc/attachment.htm>