[asterisk-dev] [Code Review] Fixing the regression from wrong set route information on provisional sip responses

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1749/#review5529
-----------------------------------------------------------


This is definitely the correct approach to take. Don't make the route persistent when building a route set from a provisional response. I have an alternative implementation in my head though. Instead of telling the build_route() function whether to make the route set persistent, just have build_route() automatically do it if the passed-in request is a SIP provisional response. That way, people can't make the mistake of using the wrong value for the persistent parameter. The correct behavior will happen every time.

- Mark


On Feb. 16, 2012, 8:20 a.m., schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1749/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2012, 8:20 a.m.)
> 
> 
> Review request for Asterisk Developers and wdoekes.
> 
> 
> Summary
> -------
> 
> by adding the parse_ok_header and build_route for provisional responses to invite. I had caused a regression that asterisk stores a wrong route set from this provisional packets. With this change a route set from a provisionial response will not be stored persistant and will be replaced with the route information from a 200 ok packet.
> see bug ASTERISK-19358 for more information and sip traces.
> 
> 
> This addresses bug ASTERISK-19358.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19358
> 
> 
> Diffs
> -----
> 
>   branches/1.8/channels/chan_sip.c 355573 
> 
> Diff: https://reviewboard.asterisk.org/r/1749/diff
> 
> 
> Testing
> -------
> 
> tested with the sipp scenario from wdoekes (thank you for this).
> 
> 
> Thanks,
> 
> schmidts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120216/cae8ebe2/attachment.htm>