[asterisk-dev] [Code Review] chan_dahdi: Add dialtonedetect option

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1737/#review5515
-----------------------------------------------------------

Ship it!


Seems good to me, but not tested.

The only concern I have with the option of 'always' (during all of the call), is if the inbound call puts us on hold with dialtone as a holdtone.. a hangup could occur.

The p->outgoing issue is an interesting one, needs to be addressed in another bug.


- Alec


On Feb. 14, 2012, 9:40 a.m., Jeremy Pepper wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1737/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2012, 9:40 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi: Add dialtonedetect option
> 
> This adds an option to chan_dahdi.conf called dialtonedetect. This can be set like this:
> 
>     dialtonedetect = yes ; Watch for dialtone for 10 seconds after answer
>     dialtonedetect = always ; Watch for dialtone for the whole call
>     dialtonedetect = 5000 ; Watch for dialtone for 5000ms
> 
> If dialtone is detected on an inbound call, Asterisk will hang up the channel.
> 
> 
> This addresses bug ASTERISK-19316.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19316
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 354459 
>   trunk/configs/chan_dahdi.conf.sample 354459 
> 
> Diff: https://reviewboard.asterisk.org/r/1737/diff
> 
> 
> Testing
> -------
> 
> This patch has been installed on an Asterisk box connected to another Asterisk box simulating an upstream carrier. Testing was done with dialtonedetect off, set to always, set to yes, and set to a custom value.
> 
> 
> Thanks,
> 
> Jeremy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120214/4d74a29c/attachment.htm>