[asterisk-dev] [Code Review] Fix unlocking typo in cel_sqlite3_custom module reload

[a_villacis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1740/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This was found while trying to isolate a deadlock on FreePBX "Apply Changes" reload in our PBX. Looks to me like a simple-to-fix typo.

[root at pbx tmp]# asterisk -rnx 'core show locks'

=======================================================================
=== Currently Held Locks ==============================================
=======================================================================
===
=== <pending> <lock#> (<file>): <lock type> <line num> <function> <lock name> <lock addr> (times locked)
===
=== Thread ID: 0x4064a940 (tps_processing_function started at [  451] taskprocessor.c ast_taskprocessor_get())
=== ---> Lock #0 (event.c): RDLOCK 1452 handle_event &(&ast_event_subs[event_types[i]])->lock 0x8348d8 (1)
	/usr/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4f2390]
	/usr/sbin/asterisk(__ast_rwlock_rdlock+0xf6) [0x4eceae]
	/usr/sbin/asterisk [0x4b65f4]
	/usr/sbin/asterisk [0x564c5e]
	/usr/sbin/asterisk [0x577618]
	/lib64/libpthread.so.0 [0x3be5a0673d]
	/lib64/libc.so.6(clone+0x6d) [0x3be4ed44bd]
=== ---> Waiting for Lock #1 (cel_sqlite3_custom.c): MUTEX 241 write_cel &lock 0x2aaac7751380 (1)
	/usr/sbin/asterisk(ast_bt_get_addresses+0x1a) [0x4f2390]
	/usr/sbin/asterisk(__ast_pthread_mutex_lock+0xf6) [0x4eac91]
	/usr/lib64/asterisk/modules/cel_sqlite3_custom.so [0x2aaac754fbf9]
	/usr/sbin/asterisk [0x4b667b]
	/usr/sbin/asterisk [0x564c5e]
	/usr/sbin/asterisk [0x577618]
	/lib64/libpthread.so.0 [0x3be5a0673d]
	/lib64/libc.so.6(clone+0x6d) [0x3be4ed44bd]
=== --- ---> Locked Here: cel_sqlite3_custom.c line 354 (reload)
=== --- ---> Locked Here: cel_sqlite3_custom.c line 356 (reload)
=== -------------------------------------------------------------------
===
=======================================================================


Diffs
-----

  /branches/1.8/cel/cel_sqlite3_custom.c 355276 

Diff: https://reviewboard.asterisk.org/r/1740/diff


Testing
-------


Thanks,

a_villacis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120214/b111bdb7/attachment.htm>