[asterisk-dev] [Code Review] chan_dahdi: Add dialtonedetect option

[Jeremy Pepper]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1737/
-----------------------------------------------------------

(Updated Feb. 13, 2012, 7:16 p.m.)


Review request for Asterisk Developers.


Changes
-------

Renamed variable dialtonedetect to dialtone_detect to match chan_dahdi.conf option
Removed redundant test for 'always' in option parsing code
Only time out dialtone detection on inbound calls, to avoid interfering with waitfordialtone
Only check for dialtone on voice frames


Summary
-------

chan_dahdi: Add dialtonedetect option

This adds an option to chan_dahdi.conf called dialtonedetect. This can be set like this:

    dialtonedetect = yes ; Watch for dialtone for 10 seconds after answer
    dialtonedetect = always ; Watch for dialtone for the whole call
    dialtonedetect = 5000 ; Watch for dialtone for 5000ms

If dialtone is detected on an inbound call, Asterisk will hang up the channel.


This addresses bug ASTERISK-19316.
    https://issues.asterisk.org/jira/browse/ASTERISK-19316


Diffs (updated)
-----

  trunk/configs/chan_dahdi.conf.sample 354459 
  trunk/channels/chan_dahdi.c 354459 

Diff: https://reviewboard.asterisk.org/r/1737/diff


Testing
-------

This patch has been installed on an Asterisk box connected to another Asterisk box simulating an upstream carrier. Testing was done with dialtonedetect off, set to always, set to yes, and set to a custom value.


Thanks,

Jeremy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120214/77b6ef10/attachment-0001.htm>